netdev - Re: [PATCH net-next 4/6] octeontx2-vf: Ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200310144551.177ddb0e@kicinski-fedora-PC1C0HJN>
Date:   Tue, 10 Mar 2020 14:45:51 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     sunil.kovvuri@...il.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Tomasz Duszynski <tduszynski@...vell.com>,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH net-next 4/6] octeontx2-vf: Ethtool support

On Wed, 11 Mar 2020 00:17:23 +0530 sunil.kovvuri@...il.com wrote:
> +static const struct ethtool_ops otx2vf_ethtool_ops = {

Please specify .supported_coalesce_params

> +	.get_link		= otx2_get_link,
> +	.get_drvinfo		= otx2vf_get_drvinfo,
> +	.get_strings		= otx2vf_get_strings,
> +	.get_ethtool_stats	= otx2vf_get_ethtool_stats,
> +	.get_sset_count		= otx2vf_get_sset_count,
> +	.set_channels		= otx2_set_channels,
> +	.get_channels		= otx2_get_channels,
> +	.get_rxnfc		= otx2_get_rxnfc,
> +	.set_rxnfc              = otx2_set_rxnfc,
> +	.get_rxfh_key_size	= otx2_get_rxfh_key_size,
> +	.get_rxfh_indir_size	= otx2_get_rxfh_indir_size,
> +	.get_rxfh		= otx2_get_rxfh,
> +	.set_rxfh		= otx2_set_rxfh,
> +	.get_ringparam		= otx2_get_ringparam,
> +	.set_ringparam		= otx2_set_ringparam,
> +	.get_coalesce		= otx2_get_coalesce,
> +	.set_coalesce		= otx2_set_coalesce,
> +	.get_msglevel		= otx2_get_msglevel,
> +	.set_msglevel		= otx2_set_msglevel,
> +	.get_pauseparam		= otx2_get_pauseparam,
> +	.set_pauseparam		= otx2_set_pauseparam,
> +};