netdev - Re: [PATCH net-next 4/6] octeontx2-vf: Ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+sq2CeTFZdH60MS1fPhfTJjSJFCn2wY6iPH+VvuLSHzkApB-w@mail.gmail.com>
Date:   Wed, 11 Mar 2020 12:09:45 +0530
From:   Sunil Kovvuri <sunil.kovvuri@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Linux Netdev List <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Tomasz Duszynski <tduszynski@...vell.com>,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH net-next 4/6] octeontx2-vf: Ethtool support

On Wed, Mar 11, 2020 at 12:51 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Wed, Mar 11, 2020 at 12:17:23AM +0530, sunil.kovvuri@...il.com wrote:
> > +int __weak otx2vf_open(struct net_device *netdev)
> > +{
> > +     return 0;
> > +}
> > +
> > +int __weak otx2vf_stop(struct net_device *netdev)
> > +{
> > +     return 0;
> > +}
>
> Hi Sunil
>
> weak symbols are very unusual in a driver. Why are they required?
>
> Thanks
>         Andrew

For ethtool configs which need interface reinitialization of interface
we need to either call PF or VF open/close fn()s.
If VF driver is not compiled in, then PF driver compilation will fail
without these weak symbols.
They are there just for compilation purpose, no other use.

Thanks,
Sunil.