netdev - Re: [PATCH] net: drop_monitor: make drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQsitL-j0Z5mBC=QWUCxG2uhv1b2oaNh1daFSRwC38A=w@mail.gmail.com>
Date:   Wed, 11 Mar 2020 15:30:34 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Neil Horman <nhorman@...driver.com>,
        Networking <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>
Cc:     Ido Schimmel <idosch@...lanox.com>, Jiri Pirko <jiri@...lanox.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Nicolas Pitre <nico@...xnic.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: drop_monitor: make drop_monitor built-in

On Wed, Mar 11, 2020 at 2:50 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> In net/Kconfig, NET_DEVLINK implies NET_DROP_MONITOR.
>
> The original behavior of the 'imply' keyword prevents NET_DROP_MONITOR
> from being 'm' when NET_DEVLINK=y.
>
> With the planned Kconfig change that relaxes the 'imply', the
> combination of NET_DEVLINK=y and NET_DROP_MONITOR=m would be allowed,
> causing a link error of vmlinux.
>
> As far as I see the mainline code, NET_DROP_MONITOR=m does not provide
> any useful case.
>
> The call-site of net_dm_hw_report() only exists in net/core/devlink.c,
> which is always built-in since NET_DEVLINK is a bool type option.
>
> So, NET_DROP_MONITOR=m causes a build error, or creates an unused
> module at best.
>
> Make NET_DROP_MONITOR a bool option, and remove the module exit code.
> I also unexported net_dm_hw_report because I see no other call-site
> in upstream.
>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>


Sorry, I take this back.
This is probably not the right fix.



I just sent an alternative patch.
( Replace IS_ENABLE with IS_REACHABLE )


-- 
Best Regards
Masahiro Yamada