netdev - Re: [PATCH net-next ct-offload v2 06/13] net/mlx5: E-Switch, Introduce global tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <428981006305a063a196e8b51ab2161b1b1d897c.camel@mellanox.com>
Date:   Tue, 10 Mar 2020 01:54:47 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     Paul Blakey <paulb@...lanox.com>,
        "marcelo.leitner@...il.com" <marcelo.leitner@...il.com>
CC:     Jiri Pirko <jiri@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Roi Dayan <roid@...lanox.com>, Oz Shlomo <ozsh@...lanox.com>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        Vlad Buslov <vladbu@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH net-next ct-offload v2 06/13] net/mlx5: E-Switch,
 Introduce global tables

On Mon, 2020-03-09 at 19:40 -0300, Marcelo Ricardo Leitner wrote:
> On Sun, Mar 08, 2020 at 04:10:55PM +0200, Paul Blakey wrote:
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> > @@ -149,7 +149,12 @@ struct mlx5_flow_handle *
> >  	if (flow_act.action & MLX5_FLOW_CONTEXT_ACTION_FWD_DEST) {
> >  		struct mlx5_flow_table *ft;
> >  
> > -		if (attr->flags & MLX5_ESW_ATTR_FLAG_SLOW_PATH) {
> > +		if (attr->dest_ft) {
> > +			flow_act.flags |= FLOW_ACT_IGNORE_FLOW_LEVEL;
> > +			dest[i].type =
> > MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE;
> > +			dest[i].ft = attr->dest_ft;
> > +			i++;
> > +		} else if (attr->flags & MLX5_ESW_ATTR_FLAG_SLOW_PATH)
> > {
> >  			flow_act.flags |= FLOW_ACT_IGNORE_FLOW_LEVEL;
> >  			dest[i].type =
> > MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE;
> >  			dest[i].ft =
> > mlx5_esw_chains_get_tc_end_ft(esw);
> > @@ -202,8 +207,11 @@ struct mlx5_flow_handle *
> >  	if (flow_act.action & MLX5_FLOW_CONTEXT_ACTION_MOD_HDR)
> >  		flow_act.modify_hdr = attr->modify_hdr;
> >  
> > -	fdb = mlx5_esw_chains_get_table(esw, attr->chain, attr->prio,
> > -					!!split);
> > +	if (attr->chain || attr->prio)
> > +		fdb = mlx5_esw_chains_get_table(esw, attr->chain, attr-
> > >prio,
> > +						!!split);
> > +	else
> > +		fdb = attr->fdb;
> 
> I'm not sure how these/mlx5 patches are supposed to propagate to
> net-next, but AFAICT here it conflicts with 
> 96e326878fa5 ("net/mlx5e: Eswitch, Use per vport tables for
> mirroring")
> 

Paul, as we agreed, this should have been rebased on top
latest net-next + ct-offloads from
git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git

Pleas rebase V3 and once the review is done on this series, i will ask
Dave to pull 
ct-offloads from
git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git

which was already reviewed and acked on netdev mailing list.

Thanks,
Saeed.