netdev - Re: [PATCH net] ipvlan: do not use cond_resched_rcu() in ipvlan_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82512911-5e8f-f60f-971c-9c1b4249dadd@gmail.com>
Date:   Mon, 9 Mar 2020 18:58:25 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Miller <davem@...emloft.net>, edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, maheshb@...gle.com
Subject: Re: [PATCH net] ipvlan: do not use cond_resched_rcu() in
 ipvlan_process_multicast()



On 3/9/20 6:33 PM, David Miller wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> Date: Mon,  9 Mar 2020 18:22:58 -0700
> 
>> Commit e18b353f102e ("ipvlan: add cond_resched_rcu() while
>> processing muticast backlog") added a cond_resched_rcu() in a loop
>> using rcu protection to iterate over slaves.
>>
>> This is breaking rcu rules, so lets instead use cond_resched()
>> at a point we can reschedule
>>
>> Fixes: e18b353f102e ("ipvlan: add cond_resched_rcu() while processing muticast backlog")
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> Cc: Mahesh Bandewar <maheshb@...gle.com>
> 
> Applied, thanks for the quick fix Eric.
> 

Sure thing ;)