lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 09 Mar 2020 18:58:45 -0700 (PDT)
From:   David Miller <>
Subject: Re: [PATCH v2 net] net: mscc: ocelot: properly account for VLAN
 header length when setting MRU

From: Vladimir Oltean <>
Date: Tue, 10 Mar 2020 03:28:18 +0200

> From: Vladimir Oltean <>
> What the driver writes into MAC_MAXLEN_CFG does not actually represent
> VLAN_ETH_FRAME_LEN but instead ETH_FRAME_LEN + ETH_FCS_LEN. Yes they are
> numerically equal, but the difference is important, as the switch treats
> VLAN-tagged traffic specially and knows to increase the maximum accepted
> frame size automatically. So it is always wrong to account for VLAN in
> the MAC_MAXLEN_CFG register.
> Unconditionally increase the maximum allowed frame size for
> double-tagged traffic. Accounting for the additional length does not
> mean that the other VLAN membership checks aren't performed, so there's
> no harm done.
> Also, stop abusing the MTU name for configuring the MRU. There is no
> support for configuring the MRU on an interface at the moment.
> Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support")
> Fixes: fa914e9c4d94 ("net: mscc: ocelot: create a helper for changing the port MTU")
> Signed-off-by: Vladimir Oltean <>
> ---
> Changes in v2:
> Rebased on net tree.

Applied and queued up for -stable, thank you.

Powered by blists - more mailing lists