netdev - Re: [PATCH net-next v4 1/6] cxgb4/chcr : Register to tls add and del callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200310023428.GB18504@gondor.apana.org.au>
Date:   Tue, 10 Mar 2020 13:34:28 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Rohit Maheshwari <rohitm@...lsio.com>, borisp@...lanox.com,
        netdev@...r.kernel.org, davem@...emloft.net, secdev@...lsio.com,
        varun@...lsio.com
Subject: Re: [PATCH net-next v4 1/6] cxgb4/chcr : Register to tls add and del
 callback

On Mon, Mar 09, 2020 at 04:10:21PM -0700, Jakub Kicinski wrote:
>
> And the driver lives in drivers/crypto for some inexplicable reason.

Indeed, and this driver scares me :)

I believe it was added to drivers/crypto because it contained
code that hooks into the crypto API to provide crypto algorithms.
At the same time the driver also provides higher-level offload
directly through the network stack.

The problem with this arrangement is that a lot of network-related
code gets into the driver with almost no review.

I think it would make much more sense to move the whole driver
(back) into drivers/net.  There is no reason why it couldn't
continue to provide crypto API implementations from drivers/net.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt