netdev - Re: [PATCH net-next v4 1/6] cxgb4/chcr : Register to tls add and del callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8d68538-a9f2-66a3-411a-ee53d7f7abb2@chelsio.com>
Date:   Tue, 10 Mar 2020 11:02:42 +0530
From:   rohit maheshwari <rohitm@...lsio.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     borisp@...lanox.com, netdev@...r.kernel.org, davem@...emloft.net,
        secdev@...lsio.com, varun@...lsio.com
Subject: Re: [PATCH net-next v4 1/6] cxgb4/chcr : Register to tls add and del
 callback


On 10/03/20 8:04 AM, Herbert Xu wrote:
> On Mon, Mar 09, 2020 at 04:10:21PM -0700, Jakub Kicinski wrote:
>> And the driver lives in drivers/crypto for some inexplicable reason.
> Indeed, and this driver scares me :)
>
> I believe it was added to drivers/crypto because it contained
> code that hooks into the crypto API to provide crypto algorithms.
> At the same time the driver also provides higher-level offload
> directly through the network stack.
>
> The problem with this arrangement is that a lot of network-related
> code gets into the driver with almost no review.
>
> I think it would make much more sense to move the whole driver
> (back) into drivers/net.  There is no reason why it couldn't
> continue to provide crypto API implementations from drivers/net.
>
> Thanks,
Since chtls (inline TOE TLS) was part of drivers/crypto, so I thought of
putting this code there as well. You are right, it makes sense to keep
only chcr co-processor part in drivers/crypto dirctory and shift complete
nic-tls and chtls code in drivers/net directory. We'll work on it ASAP.