netdev - Re: [PATCH] net: phy: Fix marvell_set_downshift() from clobbering MSCR register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200311152132.GH11247@lunn.ch>
Date:   Wed, 11 Mar 2020 16:21:32 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Darell Tan <darell.tan@...il.com>
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com, hkallweit1@...il.com,
        davem@...emloft.net
Subject: Re: [PATCH] net: phy: Fix marvell_set_downshift() from clobbering
 MSCR register

On Wed, Mar 11, 2020 at 10:41:38PM +0800, Darell Tan wrote:
> Fix marvell_set_downshift() from clobbering MSCR register.
> 
> A typo in marvell_set_downshift() clobbers the MSCR register. This
> register also shares settings with the auto MDI-X detection, set by
> marvell_set_polarity(). In the 1116R init, downshift is set after
> polarity, causing the polarity settings to be clobbered.
> 
> This bug is present on the 5.4 series and was introduced in commit
> 6ef05eb73c8f ("net: phy: marvell: Refactor setting downshift into a
> helper"). This patch need not be forward-ported to 5.5 because the
> functions were rewritten.
> 
> Signed-off-by: Darell Tan <darell.tan@...il.com>

Hi Darell

You should put net into the subject line: [patch net] ...  to indicate
this is a fix. But you have a bit of a special case here. Also, you
should indicate what it fixes:

Fixes: 6ef05eb73c8f ("net: phy: marvell: Refactor setting downshift into a helper")

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew