netdev - Re: [PATCH] vti6: Fix memory leak of skb if input policy check fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22c8ef07-70f4-e6a5-3066-357e1e688e72@6wind.com>
Date:   Thu, 12 Mar 2020 15:18:57 +0100
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Torsten Hilbrich <torsten.hilbrich@...unet.com>,
        netdev@...r.kernel.org
Cc:     Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: [PATCH] vti6: Fix memory leak of skb if input policy check fails

Le 11/03/2020 à 11:19, Torsten Hilbrich a écrit :
> The vti6_rcv function performs some tests on the retrieved tunnel
> including checking the IP protocol, the XFRM input policy, the
> source and destination address.
> 
> In all but one places the skb is released in the error case. When
> the input policy check fails the network packet is leaked.
> 
> Using the same goto-label discard in this case to fix this problem.
> 
> Signed-off-by: Torsten Hilbrich <torsten.hilbrich@...unet.com>
Fixes: ed1efb2aefbb ("ipv6: Add support for IPsec virtual tunnel interfaces")
Reviewed-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>