netdev - Re: [PATCH] vti6: Fix memory leak of skb if input policy check fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200318061553.GB19286@gauss3.secunet.de>
Date:   Wed, 18 Mar 2020 07:15:53 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
CC:     Torsten Hilbrich <torsten.hilbrich@...unet.com>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] vti6: Fix memory leak of skb if input policy check fails

On Thu, Mar 12, 2020 at 03:18:57PM +0100, Nicolas Dichtel wrote:
> Le 11/03/2020 à 11:19, Torsten Hilbrich a écrit :
> > The vti6_rcv function performs some tests on the retrieved tunnel
> > including checking the IP protocol, the XFRM input policy, the
> > source and destination address.
> > 
> > In all but one places the skb is released in the error case. When
> > the input policy check fails the network packet is leaked.
> > 
> > Using the same goto-label discard in this case to fix this problem.
> > 
> > Signed-off-by: Torsten Hilbrich <torsten.hilbrich@...unet.com>
> Fixes: ed1efb2aefbb ("ipv6: Add support for IPsec virtual tunnel interfaces")
> Reviewed-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Patch applied, thanks everyone!