lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Mar 2020 13:43:00 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Petr Machata <petrm@...lanox.com> Cc: netdev@...r.kernel.org, Roman Mashak <mrv@...atatu.com>, Eric Dumazet <eric.dumazet@...il.com>, jhs@...atatu.com, xiyou.wangcong@...il.com, davem@...emloft.net, idosch@...lanox.com, mlxsw@...lanox.com Subject: Re: [PATCH net-next v3 2/6] net: sched: Allow extending set of supported RED flags On Thu, 12 Mar 2020 20:05:03 +0200 Petr Machata wrote: > @@ -183,9 +189,12 @@ static void red_destroy(struct Qdisc *sch) > } > > static const struct nla_policy red_policy[TCA_RED_MAX + 1] = { > - [TCA_RED_PARMS] = { .len = sizeof(struct tc_red_qopt) }, > + [TCA_RED_PARMS] = { .len = sizeof(struct tc_red_qopt), > + .strict_start_type = TCA_RED_FLAGS }, I think this needs to be set on attr 0, i.e. TCA_RED_UNSPEC, otherwise feel free to add: Reviewed-by: Jakub Kicinski <kuba@...nel.org> > [TCA_RED_STAB] = { .len = RED_STAB_SIZE }, > [TCA_RED_MAX_P] = { .type = NLA_U32 }, > + [TCA_RED_FLAGS] = { .type = NLA_BITFIELD32, > + .validation_data = &red_supported_flags }, > }; > > static int red_change(struct Qdisc *sch, struct nlattr *opt,
Powered by blists - more mailing lists