netdev - Re: [PATCH net-next v3 3/6] net: sched: RED: Introduce an ECN nodrop mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200312134336.5a05a9ec@kicinski-fedora-PC1C0HJN>
Date:   Thu, 12 Mar 2020 13:43:36 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Petr Machata <petrm@...lanox.com>
Cc:     netdev@...r.kernel.org, Roman Mashak <mrv@...atatu.com>,
        Eric Dumazet <eric.dumazet@...il.com>, jhs@...atatu.com,
        xiyou.wangcong@...il.com, davem@...emloft.net, idosch@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH net-next v3 3/6] net: sched: RED: Introduce an ECN
 nodrop mode

On Thu, 12 Mar 2020 20:05:04 +0200 Petr Machata wrote:
> When the RED Qdisc is currently configured to enable ECN, the RED algorithm
> is used to decide whether a certain SKB should be marked. If that SKB is
> not ECN-capable, it is early-dropped.
> 
> It is also possible to keep all traffic in the queue, and just mark the
> ECN-capable subset of it, as appropriate under the RED algorithm. Some
> switches support this mode, and some installations make use of it.
> 
> To that end, add a new RED flag, TC_RED_NODROP. When the Qdisc is
> configured with this flag, non-ECT traffic is enqueued instead of being
> early-dropped.
> 
> Signed-off-by: Petr Machata <petrm@...lanox.com>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>