netdev - Re: [PATCH net-next v3 2/6] net: sched: Allow extending set of supported RED flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d09hxo3w.fsf@mellanox.com>
Date:   Thu, 12 Mar 2020 22:25:07 +0100
From:   Petr Machata <petrm@...lanox.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, Roman Mashak <mrv@...atatu.com>,
        Eric Dumazet <eric.dumazet@...il.com>, jhs@...atatu.com,
        xiyou.wangcong@...il.com, davem@...emloft.net, idosch@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH net-next v3 2/6] net: sched: Allow extending set of supported RED flags


Jakub Kicinski <kuba@...nel.org> writes:

> On Thu, 12 Mar 2020 20:05:03 +0200 Petr Machata wrote:
>> @@ -183,9 +189,12 @@ static void red_destroy(struct Qdisc *sch)
>>  }
>>  
>>  static const struct nla_policy red_policy[TCA_RED_MAX + 1] = {
>> -	[TCA_RED_PARMS]	= { .len = sizeof(struct tc_red_qopt) },
>> +	[TCA_RED_PARMS]	= { .len = sizeof(struct tc_red_qopt),
>> +			    .strict_start_type = TCA_RED_FLAGS },
>
> I think this needs to be set on attr 0, i.e. TCA_RED_UNSPEC,
> otherwise feel free to add:
>
> Reviewed-by: Jakub Kicinski <kuba@...nel.org>

Pretty sure. I'll send v4.