netdev - Re: [PATCH] Fix off by one in samsung driver strncpy size arg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200311.230758.1550551446954210579.davem@davemloft.net>
Date:   Wed, 11 Mar 2020 23:07:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dominik.b.czarnota@...il.com
Cc:     bh74.an@...sung.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix off by one in samsung driver strncpy size arg

From: Dominik 'disconnect3d' Czarnota <dominik.b.czarnota@...il.com>
Date: Mon,  9 Mar 2020 16:22:50 +0100

> From: disconnect3d <dominik.b.czarnota@...il.com>
> 
> This patch fixes an off-by-one error in strncpy size argument in
> drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c. The issue is that in:
> 
>         strncmp(opt, "eee_timer:", 6)
> 
> the passed string literal: "eee_timer:" has 10 bytes (without the NULL
> byte) and the passed size argument is 6. As a result, the logic will
> also accept other, malformed strings, e.g. "eee_tiXXX:".
> 
> This bug doesn't seem to have any security impact since its present in
> module's cmdline parsing code.
> 
> Signed-off-by: disconnect3d <dominik.b.czarnota@...il.com>

Applied, thank you.