lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Mar 2020 23:13:27 -0700 (PDT) From: David Miller <davem@...emloft.net> To: willemdebruijn.kernel@...il.com Cc: netdev@...r.kernel.org, mst@...hat.com, willemb@...gle.com Subject: Re: [PATCH net] net/packet: tpacket_rcv: do not increment ring index on drop From: Willem de Bruijn <willemdebruijn.kernel@...il.com> Date: Mon, 9 Mar 2020 11:34:35 -0400 > From: Willem de Bruijn <willemb@...gle.com> > > In one error case, tpacket_rcv drops packets after incrementing the > ring producer index. > > If this happens, it does not update tp_status to TP_STATUS_USER and > thus the reader is stalled for an iteration of the ring, causing out > of order arrival. > > The only such error path is when virtio_net_hdr_from_skb fails due > to encountering an unknown GSO type. > > Signed-off-by: Willem de Bruijn <willemb@...gle.com> I'm applying this, as it fixes the ring state management in this case. The question of what we should actually be doing for unknown GSO types is a separate discussion. Thanks Willem.
Powered by blists - more mailing lists