netdev - Re: [net] seg6: fix SRv6 L2 tunnels to use IANA-assigned protocol number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Mar 2020 23:50:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     paolo.lungaroni@...t.it
Cc:     kuba@...nel.org, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        andrea.mayer@...roma2.it, ahmed.abdelsalam@...i.it
Subject: Re: [net] seg6: fix SRv6 L2 tunnels to use IANA-assigned protocol
 number

From: Paolo Lungaroni <paolo.lungaroni@...t.it>
Date: Wed, 11 Mar 2020 17:54:06 +0100

> The Internet Assigned Numbers Authority (IANA) has recently assigned
> a protocol number value of 143 for Ethernet [1].
> 
> Before this assignment, encapsulation mechanisms such as Segment Routing
> used the IPv6-NoNxt protocol number (59) to indicate that the encapsulated
> payload is an Ethernet frame.
> 
> In this patch, we add the definition of the Ethernet protocol number to the
> kernel headers and update the SRv6 L2 tunnels to use it.
> 
> [1] https://www.iana.org/assignments/protocol-numbers/protocol-numbers.xhtml
> 
> Signed-off-by: Paolo Lungaroni <paolo.lungaroni@...t.it>
> Reviewed-by: Andrea Mayer <andrea.mayer@...roma2.it>
> Acked-by: Ahmed Abdelsalam <ahmed.abdelsalam@...i.it>

Applied.

But this is that classic case where we add a protocol element to the
tree before the official number is assigned.

Then the number is assigned and if we change it then everything using
the original number is no longer interoperable.