netdev - Re: [PATCH net] net: dsa: Don't instantiate phylink for CPU/DSA ports unless needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200311.234658.1725769251569186165.davem@davemloft.net>
Date:   Wed, 11 Mar 2020 23:46:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com,
        rmk+kernel@....linux.org.uk, ioana.ciornei@....com,
        olteanv@...il.com
Subject: Re: [PATCH net] net: dsa: Don't instantiate phylink for CPU/DSA
 ports unless needed

From: Andrew Lunn <andrew@...n.ch>
Date: Wed, 11 Mar 2020 16:24:24 +0100

> By default, DSA drivers should configure CPU and DSA ports to their
> maximum speed. In many configurations this is sufficient to make the
> link work.
> 
> In some cases it is necessary to configure the link to run slower,
> e.g. because of limitations of the SoC it is connected to. Or back to
> back PHYs are used and the PHY needs to be driven in order to
> establish link. In this case, phylink is used.
> 
> Only instantiate phylink if it is required. If there is no PHY, or no
> fixed link properties, phylink can upset a link which works in the
> default configuration.
> 
> Fixes: 0e27921816ad ("net: dsa: Use PHYLINK for the CPU/DSA ports")
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied and queued up for -stable, thanks.