netdev - RE: [PATCH net-next 02/15] net: dpaa: reject unsupported coalescing params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB8PR04MB6985E63146F70829DDCD9280ECFD0@DB8PR04MB6985.eurprd04.prod.outlook.com>
Date:   Thu, 12 Mar 2020 07:35:23 +0000
From:   "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "sathya.perla@...adcom.com" <sathya.perla@...adcom.com>,
        "ajit.khaparde@...adcom.com" <ajit.khaparde@...adcom.com>,
        "sriharsha.basavapatna@...adcom.com" 
        <sriharsha.basavapatna@...adcom.com>,
        "somnath.kotur@...adcom.com" <somnath.kotur@...adcom.com>,
        Andy Duan <fugang.duan@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        "yisen.zhuang@...wei.com" <yisen.zhuang@...wei.com>,
        "salil.mehta@...wei.com" <salil.mehta@...wei.com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "jacob.e.keller@...el.com" <jacob.e.keller@...el.com>,
        "alexander.h.duyck@...ux.intel.com" 
        <alexander.h.duyck@...ux.intel.com>
Subject: RE: [PATCH net-next 02/15] net: dpaa: reject unsupported coalescing
 params

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Thursday, March 12, 2020 12:33 AM
> To: davem@...emloft.net
> Subject: [PATCH net-next 02/15] net: dpaa: reject unsupported coalescing
> params
> 
> Set ethtool_ops->supported_coalesce_params to let
> the core reject unsupported coalescing parameters.
> 
> This driver did not previously reject unsupported parameters
> (other than adaptive rx, which will now be rejected by core).
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Acked-by: Madalin Bucur <madalin.bucur@....nxp.com>

> ---
>  drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
> index 6aa1fa22cd04..9db2a02fb531 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
> @@ -525,7 +525,6 @@ static int dpaa_get_coalesce(struct net_device *dev,
> 
>  	c->rx_coalesce_usecs = period;
>  	c->rx_max_coalesced_frames = thresh;
> -	c->use_adaptive_rx_coalesce = false;
> 
>  	return 0;
>  }
> @@ -540,9 +539,6 @@ static int dpaa_set_coalesce(struct net_device *dev,
>  	u8 thresh, prev_thresh;
>  	int cpu, res;
> 
> -	if (c->use_adaptive_rx_coalesce)
> -		return -EINVAL;
> -
>  	period = c->rx_coalesce_usecs;
>  	thresh = c->rx_max_coalesced_frames;
> 
> @@ -582,6 +578,8 @@ static int dpaa_set_coalesce(struct net_device *dev,
>  }
> 
>  const struct ethtool_ops dpaa_ethtool_ops = {
> +	.supported_coalesce_params = ETHTOOL_COALESCE_RX_USECS |
> +				     ETHTOOL_COALESCE_RX_MAX_FRAMES,
>  	.get_drvinfo = dpaa_get_drvinfo,
>  	.get_msglevel = dpaa_get_msglevel,
>  	.set_msglevel = dpaa_set_msglevel,
> --
> 2.24.1