netdev - RE: [EXT] [PATCH net-next 03/15] net: fec: reject unsupported coalescing params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Mar 2020 01:24:57 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Jakub Kicinski <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "sathya.perla@...adcom.com" <sathya.perla@...adcom.com>,
        "ajit.khaparde@...adcom.com" <ajit.khaparde@...adcom.com>,
        "sriharsha.basavapatna@...adcom.com" 
        <sriharsha.basavapatna@...adcom.com>,
        "somnath.kotur@...adcom.com" <somnath.kotur@...adcom.com>,
        Madalin Bucur <madalin.bucur@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        "yisen.zhuang@...wei.com" <yisen.zhuang@...wei.com>,
        "salil.mehta@...wei.com" <salil.mehta@...wei.com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "jacob.e.keller@...el.com" <jacob.e.keller@...el.com>,
        "alexander.h.duyck@...ux.intel.com" 
        <alexander.h.duyck@...ux.intel.com>
Subject: RE: [EXT] [PATCH net-next 03/15] net: fec: reject unsupported
 coalescing params

From: Jakub Kicinski <kuba@...nel.org> Sent: Thursday, March 12, 2020 6:33 AM
> Set ethtool_ops->supported_coalesce_params to let the core reject
> unsupported coalescing parameters.
> 
> This driver did not previously reject unsupported parameters.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Acked-by: Fugang Duan <fugang.duan@....com>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index af7653e341f2..ce154695f67c 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2641,6 +2641,8 @@ fec_enet_set_wol(struct net_device *ndev, struct
> ethtool_wolinfo *wol)  }
> 
>  static const struct ethtool_ops fec_enet_ethtool_ops = {
> +       .supported_coalesce_params = ETHTOOL_COALESCE_USECS |
> +
> ETHTOOL_COALESCE_MAX_FRAMES,
>         .get_drvinfo            = fec_enet_get_drvinfo,
>         .get_regs_len           = fec_enet_get_regs_len,
>         .get_regs               = fec_enet_get_regs,
> --
> 2.24.1