netdev - Re: [PATCH v2 2/2] ARM: dts: imx6q-marsboard: properly define rgmii PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200313101205.pxctcainreac7a6j@pengutronix.de>
Date:   Fri, 13 Mar 2020 11:12:05 +0100
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org, Fabio Estevam <festevam@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Mark Brown <broonie@...nel.org>, netdev@...r.kernel.org,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH v2 2/2] ARM: dts: imx6q-marsboard: properly define rgmii
 PHY

On Fri, Mar 13, 2020 at 10:55:45AM +0100, Andrew Lunn wrote:
> On Fri, Mar 13, 2020 at 06:32:24AM +0100, Oleksij Rempel wrote:
> > The Atheros AR8035 PHY can be autodetected but can't use interrupt
> > support provided on this board. Define MDIO bus and the PHY node to make
> > it work properly.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > ---
> >  arch/arm/boot/dts/imx6q-marsboard.dts | 15 ++++++++++++++-
> >  1 file changed, 14 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx6q-marsboard.dts b/arch/arm/boot/dts/imx6q-marsboard.dts
> > index 84b30bd6908f..1f31d86a217b 100644
> > --- a/arch/arm/boot/dts/imx6q-marsboard.dts
> > +++ b/arch/arm/boot/dts/imx6q-marsboard.dts
> > @@ -111,8 +111,21 @@ &fec {
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&pinctrl_enet>;
> >  	phy-mode = "rgmii-id";
> > -	phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
> >  	status = "okay";
> 
> Hi Oleksij 
> 
> I don't see a phy-handle here. So is it still using phy_find_first()?

Uff... right. Thx for pointing it.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)