netdev - Re: [PATCH bpf-next] bpf_helpers_doc.py: Fix warning when compiling bpftool.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2ac3730c-123c-df3e-0ec8-45957bbf8d8a@iogearbox.net>
Date:   Fri, 13 Mar 2020 21:13:02 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Carlos Antonio Neira Bustos <cneirabustos@...il.com>,
        Martin KaFai Lau <kafai@...com>
Cc:     netdev@...r.kernel.org, yhs@...com, quentin@...valent.com,
        ebiederm@...ssion.com, brouer@...hat.com, bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpf_helpers_doc.py: Fix warning when compiling
 bpftool.

On 3/13/20 7:23 PM, Carlos Antonio Neira Bustos wrote:
> On Fri, Mar 13, 2020 at 10:21:19AM -0700, Martin KaFai Lau wrote:
>> On Fri, Mar 13, 2020 at 12:46:50PM -0300, Carlos Neira wrote:
>>>
>>> When compiling bpftool the following warning is found:
>>> "declaration of 'struct bpf_pidns_info' will not be visible outside of this function."
>>> This patch adds struct bpf_pidns_info to type_fwds array to fix this.
>>>
>>> Signed-off-by: Carlos Neira <cneirabustos@...il.com>
>> Fixes: b4490c5c4e02 ("bpf: Added new helper bpf_get_ns_current_pid_tgid")
>> Acked-by: Martin KaFai Lau <kafai@...com>
>>
>> Please add the Fixes tag next time.  Other than tracking,
>> it will be easier for review purpose also.
> 
> Thanks, I will do that in the future.

Applied, thanks!