netdev - Re: [PATCH net] net: ip_gre: Separate ERSPAN newlink / changelink callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200315.001455.368308354303819591.davem@davemloft.net>
Date:   Sun, 15 Mar 2020 00:14:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     petrm@...lanox.com
Cc:     netdev@...r.kernel.org, u9012063@...il.com, lucien.xin@...il.com,
        mvohra@...are.com
Subject: Re: [PATCH net] net: ip_gre: Separate ERSPAN newlink / changelink
 callbacks

From: Petr Machata <petrm@...lanox.com>
Date: Fri, 13 Mar 2020 13:39:36 +0200

> ERSPAN shares most of the code path with GRE and gretap code. While that
> helps keep the code compact, it is also error prone. Currently a broken
> userspace can turn a gretap tunnel into a de facto ERSPAN one by passing
> IFLA_GRE_ERSPAN_VER. There has been a similar issue in ip6gretap in the
> past.
> 
> To prevent these problems in future, split the newlink and changelink code
> paths. Split the ERSPAN code out of ipgre_netlink_parms() into a new
> function erspan_netlink_parms(). Extract a piece of common logic from
> ipgre_newlink() and ipgre_changelink() into ipgre_newlink_encap_setup().
> Add erspan_newlink() and erspan_changelink().
> 
> Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN")
> Signed-off-by: Petr Machata <petrm@...lanox.com>

Applied and queued up for -stable, thanks.