netdev - Re: [PATCH net-next] net: mscc: ocelot: adjust maxlen on NPI port, not CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200315.001707.1935294799735002115.davem@davemloft.net>
Date:   Sun, 15 Mar 2020 00:17:07 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     horatiu.vultur@...rochip.com, alexandre.belloni@...tlin.com,
        andrew@...n.ch, f.fainelli@...il.com, vivien.didelot@...il.com,
        joergen.andreasen@...rochip.com, allan.nielsen@...rochip.com,
        claudiu.manoil@....com, netdev@...r.kernel.org,
        UNGLinuxDriver@...rochip.com, alexandru.marginean@....com,
        xiaoliang.yang_1@....com, yangbo.lu@....com, po.liu@....com
Subject: Re: [PATCH net-next] net: mscc: ocelot: adjust maxlen on NPI port,
 not CPU

From: Vladimir Oltean <olteanv@...il.com>
Date: Fri, 13 Mar 2020 15:46:51 +0200

> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> Being a non-physical port, the CPU port does not have an ocelot_port
> structure, so the ocelot_port_writel call inside the
> ocelot_port_set_maxlen() function would access data behind a NULL
> pointer.
> 
> This is a patch for net-next only, the net tree boots fine, the bug was
> introduced during the net -> net-next merge.
> 
> Fixes: 1d3435793123 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")
> Fixes: a8015ded89ad ("net: mscc: ocelot: properly account for VLAN header length when setting MRU")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

I should have been more careful with this merge conflict. :-)

Applied, thank you.