netdev - Re: [PATCH] kthread: Mark timer used by delayed kthread works as IRQ safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Mar 2020 14:23:27 +0200
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Tejun Heo <tj@...nel.org>, Petr Mladek <pmladek@...e.com>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        <linux-rt-users@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
        Richard Cochran <richardcochran@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kthread: Mark timer used by delayed kthread works as IRQ
 safe

Hi Petr,

On 19/02/2020 17:22, Tejun Heo wrote:
> On Mon, Feb 17, 2020 at 01:07:09PM +0100, Petr Mladek wrote:
>> The timer used by delayed kthread works are IRQ safe because the used
>> kthread_delayed_work_timer_fn() is IRQ safe.
>>
>> It is properly marked when initialized by KTHREAD_DELAYED_WORK_INIT().
>> But TIMER_IRQSAFE flag is missing when initialized by
>> kthread_init_delayed_work().
>>
>> The missing flag might trigger invalid warning from del_timer_sync()
>> when kthread_mod_delayed_work() is called with interrupts disabled.
>>
>> Reported-by: Grygorii Strashko <grygorii.strashko@...com>
>> Signed-off-by: Petr Mladek <pmladek@...e.com>
>> Tested-by: Grygorii Strashko <grygorii.strashko@...com>
> 
> Acked-by: Tejun Heo <tj@...nel.org>

I'm worry shouldn't this patch have "fixes" tag?

-- 
Best regards,
grygorii