netdev - Re: [PATCH net-next] cxgb4: rework TC filter rule insertion across regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200318.163916.1829921372966500306.davem@davemloft.net>
Date:   Wed, 18 Mar 2020 16:39:16 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rahul.lakkireddy@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com, vishal@...lsio.com,
        dt@...lsio.com
Subject: Re: [PATCH net-next] cxgb4: rework TC filter rule insertion across
 regions

From: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Date: Wed, 18 Mar 2020 16:24:51 +0530

> Chelsio NICs have 3 filter regions, in following order of priority:
> 1. High Priority (HPFILTER) region (Highest Priority).
> 2. HASH region.
> 3. Normal FILTER region (Lowest Priority).
> 
> Currently, there's a 1-to-1 mapping between the prio value passed
> by TC and the filter region index. However, it's possible to have
> multiple TC rules with the same prio value. In this case, if a region
> is exhausted, no attempt is made to try inserting the rule in the
> next available region.
> 
> So, rework and remove the 1-to-1 mapping. Instead, dynamically select
> the region to insert the filter rule, as long as the new rule's prio
> value doesn't conflict with existing rules across all the 3 regions.
> 
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>

Applied, thank you.