netdev - Re: [PATCH net-next] net: bridge: vlan: include stats in dumps if requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200318.164234.1141226942122598740.davem@davemloft.net>
Date:   Wed, 18 Mar 2020 16:42:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     nikolay@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next] net: bridge: vlan: include stats in dumps if
 requested

From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Date: Wed, 18 Mar 2020 15:03:25 +0200

> @@ -170,11 +170,13 @@ struct bridge_stp_xstats {
>  /* Bridge vlan RTM header */
>  struct br_vlan_msg {
>  	__u8 family;
> -	__u8 reserved1;
> +	__u8 flags;
>  	__u16 reserved2;
>  	__u32 ifindex;
>  };

I can't allow this for two reasons:

1) Userspace explicitly initializing all members will now get a compile
   failure on the reference to ->reserved1

2) Userspace not initiailizing reserved fields, which worked previously,
   might send in flags that trigger the new behavior.

Sorry, this is UAPI breakage.