netdev - Re: [PATCH net-next] net: bridge: vlan: include stats in dumps if requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dfbabebc-6c04-0df9-6fb3-46fd875674d2@cumulusnetworks.com>
Date:   Thu, 19 Mar 2020 01:49:58 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next] net: bridge: vlan: include stats in dumps if
 requested

On 3/19/20 1:42 AM, David Miller wrote:
> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> Date: Wed, 18 Mar 2020 15:03:25 +0200
> 
>> @@ -170,11 +170,13 @@ struct bridge_stp_xstats {
>>   /* Bridge vlan RTM header */
>>   struct br_vlan_msg {
>>   	__u8 family;
>> -	__u8 reserved1;
>> +	__u8 flags;
>>   	__u16 reserved2;
>>   	__u32 ifindex;
>>   };
> 
> I can't allow this for two reasons:
> 
> 1) Userspace explicitly initializing all members will now get a compile
>     failure on the reference to ->reserved1
> 
> 2) Userspace not initiailizing reserved fields, which worked previously,
>     might send in flags that trigger the new behavior.
> 
> Sorry, this is UAPI breakage.
> 

Hmm, fair enough. I'll respin with a new dump attribute which achieves the same.

Thanks.