netdev - Re: [PATCH 2/2] net: phy: marvell smi2usb mdio controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200318.165131.1855549754958829928.davem@davemloft.net>
Date:   Wed, 18 Mar 2020 16:51:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tobias@...dekranz.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] net: phy: marvell smi2usb mdio controller

From: Tobias Waldekranz <tobias@...dekranz.com>
Date: Wed, 18 Mar 2020 17:52:32 +0100

> +static int smi2usb_probe(struct usb_interface *interface,
> +			 const struct usb_device_id *id)
> +{
> +	struct smi2usb *smi;
> +	struct mii_bus *mdio;
> +	struct device *dev = &interface->dev;
> +	int err = -ENOMEM;

Please use reverse christmas tree ordering for local variables.

Thank you.