netdev - Re: [PATCH net 1/6] hinic: fix process of long length skb without frags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69cec570-7b7d-f779-3ef3-b7f658f64555@huawei.com>
Date:   Thu, 19 Mar 2020 10:37:33 +0800
From:   "luobin (L)" <luobin9@...wei.com>
To:     David Miller <davem@...emloft.net>, <kuba@...nel.org>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <aviad.krawczyk@...wei.com>, <luoxianjun@...wei.com>,
        <cloud.wangxiaoyun@...wei.com>, <yin.yinshi@...wei.com>
Subject: Re: [PATCH net 1/6] hinic: fix process of long length skb without
 frags

Ok，I will undo this patch.

On 2020/3/17 8:33, David Miller wrote:
> From: Jakub Kicinski <kuba@...nel.org>
> Date: Mon, 16 Mar 2020 14:44:08 -0700
>
>> On Mon, 16 Mar 2020 00:56:25 +0000 Luo bin wrote:
>>> -#define MIN_SKB_LEN                     17
>>> +#define MIN_SKB_LEN			17
>>> +#define HINIC_GSO_MAX_SIZE		65536
>>> +	if (unlikely(skb->len > HINIC_GSO_MAX_SIZE && nr_sges == 1)) {
>>> +		txq->txq_stats.frag_len_overflow++;
>>> +		goto skb_error;
>>> +	}
>> I don't think drivers should have to check this condition.
>>
>> We have netdev->gso_max_size which should be initialized to
>>
>> include/linux/netdevice.h:#define GSO_MAX_SIZE          65536
>>
>> in
>>
>> net/core/dev.c: dev->gso_max_size = GSO_MAX_SIZE;
>>
>> Please send a patch to pktgen to uphold the normal stack guarantees.
> Agreed, the driver should not have to validate this.
> .