netdev - Re: [[PATCH,net]] net: dsa: mt7530: Change the LINK bit to reflect the link status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200319203459.Horde.FHMW3lKtaN-qI8lZ8qts7N_@www.vdorst.com>
Date:   Thu, 19 Mar 2020 20:34:59 +0000
From:   René van Dorst <opensource@...rst.com>
To:     Vivien Didelot <vivien.didelot@...il.com>
Cc:     netdev@...r.kernel.org, Frank Wunderlich <frank-w@...lic-files.de>,
        DENG Qingfang <dqfext@...il.com>,
        Landen Chao <landen.chao@...iatek.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Russell King <linux@...linux.org.uk>,
        linux-mediatek@...ts.infradead.org,
        Andrew Smith <andrew.smith@...i.com>
Subject: Re: [[PATCH,net]] net: dsa: mt7530: Change the LINK bit to reflect
 the link status

Quoting Vivien Didelot <vivien.didelot@...il.com>:

> Hi René,
>
> On Thu, 19 Mar 2020 14:47:56 +0100, René van Dorst  
> <opensource@...rst.com> wrote:
>> Andrew reported:
>>
>> After a number of network port link up/down changes, sometimes the switch
>> port gets stuck in a state where it thinks it is still transmitting packets
>> but the cpu port is not actually transmitting anymore. In this state you
>> will see a message on the console
>> "mtk_soc_eth 1e100000.ethernet eth0: transmit timed out" and the Tx counter
>> in ifconfig will be incrementing on virtual port, but not incrementing on
>> cpu port.
>>
>> The issue is that MAC TX/RX status has no impact on the link status or
>> queue manager of the switch. So the queue manager just queues up packets
>> of a disabled port and sends out pause frames when the queue is full.
>>
>> Change the LINK bit to reflect the link status.
>>
>> Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek  
>> MT7530 switch")
>> Reported-by: Andrew Smith <andrew.smith@...i.com>
>> Signed-off-by: René van Dorst <opensource@...rst.com>
>

Hi Vivien,

> Reviewed-by: Vivien Didelot <vivien.didelot@...il.com>
>
> For the subject prefix, it is preferable to use "[PATCH net]" over
> "[[PATCH,net]]". You can easily add this bracketed prefix with git
> format-patch's option --subject-prefix="PATCH net".

Thanks for reviewing.

Funny is that I used subject-prefix option but I with the brackets.
Like --subject-prefix="[PATCH,net]" but not realizing that git also
add brackets. I didn't noticed until I got an email back from the
mailinglist that it had double brackets.
Next time I use "[PATCH net]".

Great,

René


>
>
> Thank you,
>
> 	Vivien