netdev - Re: [[PATCH,net]] net: dsa: mt7530: Change the LINK bit to reflect the link status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200319.211142.227637721585547364.davem@davemloft.net>
Date:   Thu, 19 Mar 2020 21:11:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     opensource@...rst.com
Cc:     netdev@...r.kernel.org, frank-w@...lic-files.de, dqfext@...il.com,
        landen.chao@...iatek.com, sean.wang@...iatek.com, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        matthias.bgg@...il.com, linux@...linux.org.uk,
        linux-mediatek@...ts.infradead.org, andrew.smith@...i.com
Subject: Re: [[PATCH,net]] net: dsa: mt7530: Change the LINK bit to reflect
 the link status

From: René van Dorst <opensource@...rst.com>
Date: Thu, 19 Mar 2020 14:47:56 +0100

> Andrew reported:
> 
> After a number of network port link up/down changes, sometimes the switch
> port gets stuck in a state where it thinks it is still transmitting packets
> but the cpu port is not actually transmitting anymore. In this state you
> will see a message on the console
> "mtk_soc_eth 1e100000.ethernet eth0: transmit timed out" and the Tx counter
> in ifconfig will be incrementing on virtual port, but not incrementing on
> cpu port.
> 
> The issue is that MAC TX/RX status has no impact on the link status or
> queue manager of the switch. So the queue manager just queues up packets
> of a disabled port and sends out pause frames when the queue is full.
> 
> Change the LINK bit to reflect the link status.
> 
> Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch")
> Reported-by: Andrew Smith <andrew.smith@...i.com>
> Signed-off-by: René van Dorst <opensource@...rst.com>

Applied and queued up for -stable, thanks.