netdev - Re: [PATCH net-next] net: mptcp: don't hang in mptcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Mar 2020 16:54:45 +0100
From:   Matthieu Baerts <matthieu.baerts@...sares.net>
To:     Paolo Abeni <pabeni@...hat.com>,
        Davide Caratti <dcaratti@...hat.com>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, mptcp@...ts.01.org
Subject: Re: [PATCH net-next] net: mptcp: don't hang in mptcp_sendmsg() after
 TCP fallback

On 19/03/2020 23:48, Paolo Abeni wrote:
> On Thu, 2020-03-19 at 22:45 +0100, Davide Caratti wrote:
>> it's still possible for packetdrill to hang in mptcp_sendmsg(), when the
>> MPTCP socket falls back to regular TCP (e.g. after receiving unsupported
>> flags/version during the three-way handshake). Adjust MPTCP socket state
>> earlier, to ensure correct functionality of mptcp_sendmsg() even in case
>> of TCP fallback.
>>
>> Fixes: 767d3ded5fb8 ("net: mptcp: don't hang before sending 'MP capable with data'")
>> Fixes: 1954b86016cf ("mptcp: Check connection state before attempting send")
>> Signed-off-by: Davide Caratti <dcaratti@...hat.com>
> 
> LGTM, thanks Davide!
> 
> Acked-by: Paolo Abeni <pabeni@...hat.com>

LGTM too, thanks Davide and Paolo!

Reviewed-by: Matthieu Baerts <matthieu.baerts@...sares.net>