netdev - Re: [PATCH net] tcp: also NULL skb->dev when copy was needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc8b3834-f9f4-d5e9-f2e7-7e40249e7609@gmail.com>
Date:   Fri, 20 Mar 2020 10:14:06 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Florian Westphal <fw@...len.de>, netdev@...r.kernel.org
Cc:     Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net] tcp: also NULL skb->dev when copy was needed



On 3/20/20 8:52 AM, Florian Westphal wrote:
> In rare cases retransmit logic will make a full skb copy, which will not
> trigger the zeroing added in recent change
> b738a185beaa ("tcp: ensure skb->dev is NULL before leaving TCP stack").
> 
> Cc: Eric Dumazet <edumazet@...gle.com>
> Fixes: 75c119afe14f ("tcp: implement rb-tree based retransmit queue")
> Fixes: 28f8bfd1ac94 ("netfilter: Support iif matches in POSTROUTING")
> Signed-off-by: Florian Westphal <fw@...len.de>
> ---

Good catch, thanks Florian !

Signed-off-by: Eric Dumazet <edumazet@...gle.com>