netdev - Re: [PATCH v3 net-next 4/8] octeontx2-vf: Ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200320101451.0036a8cc@kicinski-fedora-PC1C0HJN>
Date:   Fri, 20 Mar 2020 10:14:51 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sunil Kovvuri <sunil.kovvuri@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Linux Netdev List <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Leon Romanovsky <leon@...nel.org>,
        Tomasz Duszynski <tduszynski@...vell.com>,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH v3 net-next 4/8] octeontx2-vf: Ethtool support

On Fri, 20 Mar 2020 12:35:15 +0530 Sunil Kovvuri wrote:
> On Fri, Mar 20, 2020 at 4:12 AM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Thu, 19 Mar 2020 16:56:31 +0100 Andrew Lunn wrote:  
> > > On Thu, Mar 19, 2020 at 06:37:24PM +0530, sunil.kovvuri@...il.com wrote:  
> > > > From: Tomasz Duszynski <tduszynski@...vell.com>
> > > >
> > > > Added ethtool support for VF devices for
> > > >  - Driver stats, Tx/Rx perqueue stats
> > > >  - Set/show Rx/Tx queue count
> > > >  - Set/show Rx/Tx ring sizes
> > > >  - Set/show IRQ coalescing parameters
> > > >  - RSS configuration etc
> > > >
> > > > It's the PF which owns the interface, hence VF
> > > > cannot display underlying CGX interface stats.
> > > > Except for this rest ethtool support reuses PF's
> > > > APIs.
> > > >
> > > > Signed-off-by: Tomasz Duszynski <tduszynski@...vell.com>
> > > > Signed-off-by: Sunil Goutham <sgoutham@...vell.com>  
> > >
> > > Reviewed-by: Andrew Lunn <andrew@...n.ch>  
> >
> > But they didn't add static inlines, no? Don't the dependencies
> > look strange?
> >
> > VF depends on PF code, but ethtool code (part of PF) also needs
> > symbols from the VF..
> >  
> 
> ethtool code has no dependency on symbols from the VF driver.
> PF driver compiles and module loads fine without enabling VF driver.
> While getting rid of __weak fn()s i forgot to remove EXPORT symbols
> from VF driver.
> I will remove and resubmit.

I see. I saw the exports and assumed it gets called. Thanks.