netdev - Re: [PATCH net-next] ethtool: remove XCVR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 22 Mar 2020 15:08:37 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] ethtool: remove XCVR_DUMMY entries

On Sun, Mar 22, 2020 at 02:14:20PM +0100, Heiner Kallweit wrote:
> The transceiver dummy entries are not used any longer, so remove them.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  include/uapi/linux/ethtool.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> index d586ee5e1..77721ea36 100644
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -1673,9 +1673,6 @@ static inline int ethtool_validate_duplex(__u8 duplex)
>  /* Which transceiver to use. */
>  #define XCVR_INTERNAL		0x00 /* PHY and MAC are in the same package */
>  #define XCVR_EXTERNAL		0x01 /* PHY and MAC are in different packages */
> -#define XCVR_DUMMY1		0x02
> -#define XCVR_DUMMY2		0x03
> -#define XCVR_DUMMY3		0x04

Hi Heiner

We need to be careful here. This is a UAPI header. The kernel might
not use them, but is there any user space code using them?

A quick search found:

http://www.infradead.org/~tgr/libnl/doc/api/ethtool_8c_source.html

	Andrew