netdev - Re: [PATCH] net: PHY: bcm-unimac: Fix clock handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a190001-db8a-4c4c-909e-9ef475a58ed3@gmail.com>
Date:   Tue, 24 Mar 2020 10:13:53 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     André Przywara <andre.przywara@....com>,
        Andrew Lunn <andrew@...n.ch>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Doug Berger <opendmb@...il.com>
Subject: Re: [PATCH] net: PHY: bcm-unimac: Fix clock handling



On 3/24/2020 9:26 AM, André Przywara wrote:
> On 24/03/2020 16:17, Andrew Lunn wrote:
> 
> Hi,
> 
>> On Tue, Mar 24, 2020 at 04:10:10PM +0000, Andre Przywara wrote:
>>> The DT binding for this PHY describes an *optional* clock property.
>>> Due to a bug in the error handling logic, we are actually ignoring this
>>> clock *all* of the time so far.
>>>
>>> Fix this by using devm_clk_get_optional() to handle this clock properly.
>>>
>>> Signed-off-by: Andre Przywara <andre.przywara@....com>
>>
>> Hi Andre
>>
>> Do you have a fixes: tag for this?
> 
> Should be:
> Fixes: b78ac6ecd1b6b ("net: phy: mdio-bcm-unimac: Allow configuring MDIO
> clock divider")
> 
>> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
> Thanks for that!

And the subject should be:

net: phy: mdio-bcm-unimac: Fix clock handling

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian