netdev - Re: [PATCH] net: PHY: bcm-unimac: Fix clock handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200324.164612.1971775620100257616.davem@davemloft.net>
Date:   Tue, 24 Mar 2020 16:46:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andre.przywara@....com
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        linux@...linux.org.uk, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, opendmb@...il.com
Subject: Re: [PATCH] net: PHY: bcm-unimac: Fix clock handling

From: Andre Przywara <andre.przywara@....com>
Date: Tue, 24 Mar 2020 16:10:10 +0000

> The DT binding for this PHY describes an *optional* clock property.
> Due to a bug in the error handling logic, we are actually ignoring this
> clock *all* of the time so far.
> 
> Fix this by using devm_clk_get_optional() to handle this clock properly.
> 
> Signed-off-by: Andre Przywara <andre.przywara@....com>

Applied with Fixes tag added and Subject line corrected.

Thanks.