netdev - Re: [PATCH net-next] ethtool: fix incorrect tx-checksumming settings reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200324.162536.1931215402668902440.davem@davemloft.net>
Date:   Tue, 24 Mar 2020 16:25:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vladyslavt@...lanox.com
Cc:     netdev@...r.kernel.org, maximmi@...lanox.com, mkubecek@...e.cz,
        moshe@...lanox.com
Subject: Re: [PATCH net-next] ethtool: fix incorrect tx-checksumming
 settings reporting

From: Vladyslav Tarasiuk <vladyslavt@...lanox.com>
Date: Tue, 24 Mar 2020 13:57:08 +0200

> Currently, ethtool feature mask for checksum command is ORed with
> NETIF_F_FCOE_CRC_BIT, which is bit's position number, instead of the
> actual feature bit - NETIF_F_FCOE_CRC.
> 
> The invalid bitmask here might affect unrelated features when toggling
> TX checksumming. For example, TX checksumming is always mistakenly
> reported as enabled on the netdevs tested (mlx5, virtio_net).
> 
> Fixes: f70bb06563ed ("ethtool: update mapping of features to legacy ioctl requests")
> Signed-off-by: Vladyslav Tarasiuk <vladyslavt@...lanox.com>

Applied, thanks.