netdev - Re: [PATCH net-next] net: phy: mscc: consolidate a common RGMII delay implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200324.163651.1067037521170220223.davem@davemloft.net>
Date:   Tue, 24 Mar 2020 16:36:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     antoine.tenart@...tlin.com
Cc:     andrew@...n.ch, olteanv@...il.com, netdev@...r.kernel.org,
        f.fainelli@...il.com, hkallweit1@...il.com
Subject: Re: [PATCH net-next] net: phy: mscc: consolidate a common RGMII
 delay implementation

From: Antoine Tenart <antoine.tenart@...tlin.com>
Date: Tue, 24 Mar 2020 15:49:37 +0100

> Hi Vladimir,
> 
> Quoting Andrew Lunn (2020-03-24 15:18:29)
>> On Tue, Mar 24, 2020 at 04:13:58PM +0200, Vladimir Oltean wrote:
>> > From: Vladimir Oltean <vladimir.oltean@....com>
>> > 
>> > It looks like the VSC8584 PHY driver is rolling its own RGMII delay
>> > configuration code, despite the fact that the logic is mostly the same.
>> > 
>> > In fact only the register layout and position for the RGMII controls has
>> > changed. So we need to adapt and parameterize the PHY-dependent bit
>> > fields when calling the new generic function.
>> > 
>> > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
>> 
>> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
> Tested-by: Antoine Tenart <antoine.tenart@...tlin.com>

Applied, thanks everyone.