netdev - Re: [PATCH net-next] net: phy: mscc: consolidate a common RGMII delay implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hqw3in1aX9hWOSYqn+qOAbUo4YBtx-djvvVLmQeBCNw=A@mail.gmail.com>
Date:   Tue, 24 Mar 2020 16:51:44 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Antoine Tenart <antoine.tenart@...tlin.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH net-next] net: phy: mscc: consolidate a common RGMII delay implementation

On Tue, 24 Mar 2020 at 16:49, Antoine Tenart <antoine.tenart@...tlin.com> wrote:
>
> Hi Vladimir,
>
> Quoting Andrew Lunn (2020-03-24 15:18:29)
> > On Tue, Mar 24, 2020 at 04:13:58PM +0200, Vladimir Oltean wrote:
> > > From: Vladimir Oltean <vladimir.oltean@....com>
> > >
> > > It looks like the VSC8584 PHY driver is rolling its own RGMII delay
> > > configuration code, despite the fact that the logic is mostly the same.
> > >
> > > In fact only the register layout and position for the RGMII controls has
> > > changed. So we need to adapt and parameterize the PHY-dependent bit
> > > fields when calling the new generic function.
> > >
> > > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> >
> > Reviewed-by: Andrew Lunn <andrew@...n.ch>
>
> Tested-by: Antoine Tenart <antoine.tenart@...tlin.com>
>
> Thanks!
> Antoine
>
> --
> Antoine Ténart, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Thanks for testing, Antoine!