netdev - Re: [PATCH 01/14] net: ks8851: Factor out spi->dev in probe()/remove()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200324064638.szp3nfbccthfvqu6@wunner.de>
Date:   Tue, 24 Mar 2020 07:46:38 +0100
From:   Lukas Wunner <lukas@...ner.de>
To:     Marek Vasut <marex@...x.de>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Petr Stetiar <ynezz@...e.cz>,
        YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH 01/14] net: ks8851: Factor out spi->dev in
 probe()/remove()

On Tue, Mar 24, 2020 at 12:42:50AM +0100, Marek Vasut wrote:
> -	gpio = of_get_named_gpio_flags(spi->dev.of_node, "reset-gpios",
> +	gpio = of_get_named_gpio_flags(dev->of_node, "reset-gpios",
>  				       0, NULL);
>  	if (gpio == -EPROBE_DEFER) {
>  		ret = gpio;

Nit: It would be nice to unwrap the line since it is shorter than
80 chars even with "0, NULL);" appended.


> @@ -1456,12 +1457,12 @@ static int ks8851_probe(struct spi_device *spi)
>  
>  	ret = regulator_enable(ks->vdd_io);
>  	if (ret) {
> -		dev_err(&spi->dev, "regulator vdd_io enable fail: %d\n",
> +		dev_err(dev, "regulator vdd_io enable fail: %d\n",
>  			ret);
>  		goto err_reg_io;
>  	}

Same here.


> @@ -1469,7 +1470,7 @@ static int ks8851_probe(struct spi_device *spi)
>  
>  	ret = regulator_enable(ks->vdd_reg);
>  	if (ret) {
> -		dev_err(&spi->dev, "regulator vdd enable fail: %d\n",
> +		dev_err(dev, "regulator vdd enable fail: %d\n",
>  			ret);
>  		goto err_reg;
>  	}

Same.

Thanks,

Lukas