netdev - Re: [PATCH 08/10] devlink: implement DEVLINK_CMD_REGION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200325104641.24b7ce5c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 25 Mar 2020 10:46:41 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Jacob Keller <jacob.e.keller@...el.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 08/10] devlink: implement DEVLINK_CMD_REGION_NEW

On Wed, 25 Mar 2020 18:20:36 +0100 Jiri Pirko wrote:
> Wed, Mar 25, 2020 at 06:18:04PM CET, kuba@...nel.org wrote:
> >On Wed, 25 Mar 2020 17:46:22 +0100 Jiri Pirko wrote:  
> >> >+	err = region->ops->snapshot(devlink, info->extack, &data);
> >> >+	if (err)
> >> >+		goto err_decrement_snapshot_count;
> >> >+
> >> >+	err = __devlink_region_snapshot_create(region, data, snapshot_id);
> >> >+	if (err)
> >> >+		goto err_free_snapshot_data;
> >> >+
> >> >+	return 0;
> >> >+
> >> >+err_decrement_snapshot_count:
> >> >+	__devlink_snapshot_id_decrement(devlink, snapshot_id);
> >> >+err_free_snapshot_data:    
> >> 
> >> In devlink the error labers are named according to actions that failed.  
> >
> >Can we leave this to the author of the code to decide?  
> 
> Well, if you look at 1 .c file, the reader should see one style. So...

Fine :)