netdev - Re: [PATCH 04/10] devlink: add function to take snapshot while locked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200325105608.13077942@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 25 Mar 2020 10:56:08 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     netdev@...r.kernel.org, Jiri Pirko <jiri@...nulli.us>,
        Jiri Pirko <jiri@...lanox.com>
Subject: Re: [PATCH 04/10] devlink: add function to take snapshot while
 locked

On Tue, 24 Mar 2020 15:34:39 -0700 Jacob Keller wrote:
> A future change is going to add a new devlink command to request
> a snapshot on demand. This function will want to call the
> devlink_region_snapshot_create function while already holding the
> devlink instance lock.
> 
> Extract the logic of this function into a static function prefixed by
> `__` to indicate that it is an internal helper function. Modify the
> original function to be implemented in terms of the new locked
> function.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>