netdev - Re: [net-next v2 09/11] devlink: implement DEVLINK_CMD_REGION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200326085239.GO11304@nanopsycho.orion>
Date:   Thu, 26 Mar 2020 09:52:39 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [net-next v2 09/11] devlink: implement DEVLINK_CMD_REGION_NEW

Thu, Mar 26, 2020 at 04:51:55AM CET, jacob.e.keller@...el.com wrote:

[...]

>+	err = __devlink_snapshot_id_insert(devlink, snapshot_id);
>+	if (err) {
>+		return err;
>+	}
>+
>+	err = region->ops->snapshot(devlink, info->extack, &data);
>+	if (err)
>+		goto snapshot_capture_failure;
>+
>+	err = __devlink_region_snapshot_create(region, data, snapshot_id);
>+	if (err)
>+		goto snapshot_create_failure;
>+
>+	return 0;
>+
>+snapshot_create_failure:
>+	region->ops->destructor(data);
>+snapshot_capture_failure:

Eh, this actually should be "err_snapshot_capture" and
"err_snapshot_create"


>+	__devlink_snapshot_id_decrement(devlink, snapshot_id);
>+	return err;
>+}
>+

[...]