[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200326085440.GA4694@nanopsycho.orion>
Date: Thu, 26 Mar 2020 09:54:40 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [net-next v2 00/11] implement DEVLINK_CMD_REGION_NEW
Thu, Mar 26, 2020 at 04:51:46AM CET, jacob.e.keller@...el.com wrote:
[...]
> * devlink: implement DEVLINK_CMD_REGION_NEW
>
> Added a WARN_ON to the check in snapshot_id_insert in case the id already
> exists.
>
> Removed an unnecessary "if (err) { return err; }" construction
>
> Use -ENOSPC instead of -ENOMEM when max_snapshots is reached.
>
> Cleanup label names to match style of the other labels in the file,
> naming after the failure cause rather than the cleanup step. Also fix a
> bug in the label ordering.
>
> Call the new devlink_region_snapshot_id_put function in the mlx4 and
> netdevsim drivers.
This belongs to a different patch. This would not happen if you'd have
per-patch changelog :)
[...]
Powered by blists - more mailing lists