netdev - Re: [PATCH net-next 0/3] Implement stats_update callback for pedit and skbedit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82146B35-23D2-437A-8052-E0DC6488D08A@mellanox.com>
Date:   Fri, 27 Mar 2020 00:01:12 +0000
From:   Alexander Petrovskiy <alexpe@...lanox.com>
To:     Petr Machata <petrm@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     David Miller <davem@...emloft.net>,
        Ido Schimmel <idosch@...lanox.com>,
        Jiri Pirko <jiri@...lanox.com>
Subject: Re: [PATCH net-next 0/3] Implement stats_update callback for pedit
 and skbedit

On 26.03.2020, 23:46, "Petr Machata" <petrm@...lanox.com> wrote:

>The stats_update callback is used for adding HW counters to the SW ones.
>Both skbedit and pedit actions are actually recognized by flow_offload.h,
>but do not implement these callbacks. As a consequence, the reported values
>are only the SW ones, even where there is a HW counter available.
>
>Patch #1 adds the callback to action skbedit, patch #2 adds it to action
>pedit. Patch #3 tweaks an skbedit selftest with a check that would have
>caught this problem.
>
>The pedit test is not likewise tweaked, because the iproute2 pedit action
>currently does not support JSON dumping. This will be addressed later.
>
>Petr Machata (3):
>  sched: act_skbedit: Implement stats_update callback
>  sched: act_pedit: Implement stats_update callback
>  selftests: skbedit_priority: Test counters at the skbedit rule
>
> net/sched/act_pedit.c                                 | 11 +++++++++++
> net/sched/act_skbedit.c                               | 11 +++++++++++
> .../selftests/net/forwarding/skbedit_priority.sh      |  9 +++++++--
> 3 files changed, 29 insertions(+), 2 deletions(-)
>
>-- 
>2.20.1

Tested-by: Alexander Petrovskiy <alexpe@...lanox.com>