netdev - Re: [PATCH net-next 0/3] Implement stats_update callback for pedit and skbedit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200326.192052.575550840173150215.davem@davemloft.net>
Date:   Thu, 26 Mar 2020 19:20:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     petrm@...lanox.com
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, jiri@...lanox.com,
        alexpe@...lanox.com
Subject: Re: [PATCH net-next 0/3] Implement stats_update callback for pedit
 and skbedit

From: Petr Machata <petrm@...lanox.com>
Date: Thu, 26 Mar 2020 22:45:54 +0200

> The stats_update callback is used for adding HW counters to the SW ones.
> Both skbedit and pedit actions are actually recognized by flow_offload.h,
> but do not implement these callbacks. As a consequence, the reported values
> are only the SW ones, even where there is a HW counter available.
> 
> Patch #1 adds the callback to action skbedit, patch #2 adds it to action
> pedit. Patch #3 tweaks an skbedit selftest with a check that would have
> caught this problem.
> 
> The pedit test is not likewise tweaked, because the iproute2 pedit action
> currently does not support JSON dumping. This will be addressed later.

Series applied, thanks Petr.