netdev - Re: [PATCH net-next v2 07/17] mptcp: queue data for mptcp level retransmission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200326.192907.1502687986030002778.davem@davemloft.net>
Date:   Thu, 26 Mar 2020 19:29:07 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mathew.j.martineau@...ux.intel.com
Cc:     netdev@...r.kernel.org, pabeni@...hat.com, eric.dumazet@...il.com
Subject: Re: [PATCH net-next v2 07/17] mptcp: queue data for mptcp level
 retransmission

From: Mat Martineau <mathew.j.martineau@...ux.intel.com>
Date: Thu, 26 Mar 2020 13:46:30 -0700

> @@ -285,15 +285,75 @@ static inline bool mptcp_skb_can_collapse_to(const struct mptcp_sock *msk,
>  	return mpext && mpext->data_seq + mpext->data_len == msk->write_seq;
>  }
>  
> +static inline bool mptcp_frag_can_collapse_to(const struct mptcp_sock *msk,
> +					      const struct page_frag *pfrag,
> +					      const struct mptcp_data_frag *df)

Please don't use inline in foo.c files, let the compiler decide.