netdev - Re: [PATCH net-next v2] netfilter: Fix incorrect tc_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200327162345.jcas4dez5ximalvn@salvia>
Date:   Fri, 27 Mar 2020 17:23:45 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     David Miller <davem@...emloft.net>
Cc:     wenxu@...oud.cn, netdev@...r.kernel.org,
        netfilter-devel@...r.kernel.org
Subject: Re: [PATCH net-next v2] netfilter: Fix incorrect tc_setup_type type
 for flowtable offload

On Thu, Mar 26, 2020 at 08:04:09PM -0700, David Miller wrote:
> From: wenxu@...oud.cn
> Date: Tue, 24 Mar 2020 07:34:25 +0800
> 
> > From: wenxu <wenxu@...oud.cn>
> > 
> > Flowtable offload setup flow_offlod_block in TC_SETP_FT. The indr block
> > offload of flowtable also should setup in TC_SETUP_FT.
> > But flow_indr_block_call always sets the tc_set_up_type as TC_SETUP_BLOCK.
> > So function flow_indr_block_call should expose a parameters to set
> > the tc_setup_type for each offload subsystem.
> > 
> > Fixes: b5140a36da78 ("netfilter: flowtable: add indr block setup support")
> > Signed-off-by: wenxu <wenxu@...oud.cn>
> > ---
> > v2: modify the comments
> 
> Do the netfilter folks want to take this or should I apply it directly?

We'll take care of this patch, thank you.